linux-kernel - Re: [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Feb 2012 23:56:22 -0600 (CST)
From:	Manoj Iyer <manoj.iyer@...onical.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
cc:	Manoj Iyer <manoj.iyer@...onical.com>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] Input: atkbd - Add force relese key quirk for HP
 ProBook

Dimitry,

This quirk helps a few HP ProBooks to make brightness keys typematic. Can 
you please tell me why you think its better handling this in user space? I 
see other quirks similar to this in atkbd, just trying to understand. Yes, 
we did quirk this in udev rules to make brightness keys works as expected. 
But thought it might help others who see this issue with HP ProBooks by 
quirking it in kernel.

Thanks
Manoj



On Tue, 28 Feb 2012, Dmitry Torokhov wrote:

> On Tue, Feb 28, 2012 at 04:46:04PM -0800, Greg KH wrote:
>> On Tue, Feb 28, 2012 at 06:36:10PM -0600, Manoj Iyer wrote:
>>> HP ProBooks do not send a key release for brightness keys, as a
>>> result, brightness does not move up/down when the brightness key
>>> is held down. This quirk makes the brightness keys on HP ProBooks
>>> typematic.
>>>
>>> Signed-off-by: Manoj Iyer <manoj.iyer@...onical.com>
>>> ---
>>>  drivers/input/keyboard/atkbd.c |   16 ++++++++++++++++
>>>  1 files changed, 16 insertions(+), 0 deletions(-)
>>
>> <formletter>
>>
>> This is not the correct way to submit patches for inclusion in the
>> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
>> for how to do this properly.
>>
>> </formletter>
>
> Also, this should be handled from userspace by having usev write to
> /sys/bus/serio/devices/serioX/force_release attribute on affected boxes.
>
> -- 
> Dmitry
>
>

--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/