linux-kernel - Re: [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120229061715.GA13131@core.coreip.homeip.net>
Date:	Tue, 28 Feb 2012 22:17:15 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Manoj Iyer <manoj.iyer@...onical.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] Input: atkbd - Add force relese key quirk for HP ProBook

Hi Manoj,

On Tue, Feb 28, 2012 at 11:56:22PM -0600, Manoj Iyer wrote:
> Dimitry,
> 
> This quirk helps a few HP ProBooks to make brightness keys
> typematic. Can you please tell me why you think its better handling
> this in user space?

Because there are too many broken laptops to quirk them all in kernel as
every quirk takes non-swappable kernel memory whereas userspace solution
only takes disk space.

> I see other quirks similar to this in atkbd,
> just trying to understand.

These were added before I implemented support for allowing marking some
of the keys as "force release" via sysfs attribute.

> Yes, we did quirk this in udev rules to
> make brightness keys works as expected. But thought it might help
> others who see this issue with HP ProBooks by quirking it in kernel.
> 

If you submit your quirk to udev maintainers you will help others
exactly the same as with kernel patch.

Thanks.

-- 
Dmitry

P.S. Please do not top post.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/