linux-kernel - Re: [PATCH 1/2] staging: zcache: fix length type mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120229062220.GA22598@mwanda>
Date:	Wed, 29 Feb 2012 09:22:20 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>,
	linux-kernel@...r.kernel.org,
	Robert Jennings <rcj@...ux.vnet.ibm.com>,
	Nitin Gupta <ngupta@...are.org>
Subject: Re: [PATCH 1/2] staging: zcache: fix length type mismatch

On Tue, Feb 28, 2012 at 04:01:37PM -0600, Seth Jennings wrote:
> This fixes a type mismatch in the compression code where
> a size_t pointer was cast to a unsigned int pointer.  On
> little endian archs, there is no issue.  However on big
> endian archs, the value is incorrect, taking the high
> order bits and truncating the lower order bits.

I would think this would be a problem on any 64bit machine not just
big endian ones.  Since clen is half uninitialized we would likely
hit the clen > zbud_max_buddy_size() test.

Anyway the patch is right.

regards,
dan carpenter



Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)