linux-kernel - Re: [PATCH] [media] s5p-g2d: Make it possible to instantiate driver from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJuYYwQ54idFZGvyujimrhhedSveK9ob8j+686D6ABdavAA_SA@mail.gmail.com>
Date:	Thu, 1 Mar 2012 08:50:59 +0530
From:	Thomas Abraham <thomas.abraham@...aro.org>
To:	Karol Lewandowski <k.lewandowsk@...sung.com>
Cc:	k.debski@...sung.com, m.szyprowski@...sung.com,
	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-samsung-soc@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH] [media] s5p-g2d: Make it possible to instantiate driver
 from DT

On 29 February 2012 19:24, Karol Lewandowski <k.lewandowsk@...sung.com> wrote:
> This driver requires standard properties only (address and irq)
> which are automatically marshalled into plain old resources by OF core.
>
> Signed-off-by: Karol Lewandowski <k.lewandowsk@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---
>  drivers/media/video/s5p-g2d/g2d.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/s5p-g2d/g2d.c b/drivers/media/video/s5p-g2d/g2d.c
> index febaa67..e7c0020 100644
> --- a/drivers/media/video/s5p-g2d/g2d.c
> +++ b/drivers/media/video/s5p-g2d/g2d.c
> @@ -20,6 +20,7 @@
>  #include <linux/interrupt.h>
>
>  #include <linux/platform_device.h>
> +#include <linux/of.h>
>  #include <media/v4l2-mem2mem.h>
>  #include <media/v4l2-device.h>
>  #include <media/v4l2-ioctl.h>
> @@ -795,12 +796,20 @@ static int g2d_remove(struct platform_device *pdev)
>        return 0;
>  }
>
> +#ifdef CONFIG_OF
> +static struct of_device_id g2d_dt_match[] = {
> +       { .compatible = "samsung,exynos4210-g2d" },

The comment about the base version in the previous patch applies here too.

> +       {},
> +};
> +#endif
> +
>  static struct platform_driver g2d_pdrv = {
>        .probe          = g2d_probe,
>        .remove         = g2d_remove,
>        .driver         = {
>                .name = G2D_NAME,
>                .owner = THIS_MODULE,
> +               .of_match_table = of_match_ptr(g2d_dt_match),
>        },
>  };
>
> --
> 1.7.8.3

Reviewed-by: Thomas Abraham <thomas.abraham@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/