linux-kernel - Re: [PATCH 2/5] OpenRISC: Use generic bitops.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330671026.19557.99.camel@satguru>
Date:	Fri, 02 Mar 2012 07:50:26 +0100
From:	Jonas Bonn <jonas@...thpole.se>
To:	Richard Weinberger <richard@....at>
Cc:	linux@...ts.openrisc.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] OpenRISC: Use generic bitops.h

On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
> There is no need to reinvent the wheel.

NAK... we have optimized versions for some of these operations so the
generic header isn't right for us.

Have a look at arch/openrisc/asm/include/bitops.h to see which functions
we override with accelerated versions.

/Jonas

> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  arch/openrisc/include/asm/Kbuild |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/openrisc/include/asm/Kbuild b/arch/openrisc/include/asm/Kbuild
> index 11162e6..a283165 100644
> --- a/arch/openrisc/include/asm/Kbuild
> +++ b/arch/openrisc/include/asm/Kbuild
> @@ -4,6 +4,7 @@ header-y += spr_defs.h
>  
>  generic-y += atomic.h
>  generic-y += auxvec.h
> +generic-y += bitops.h
>  generic-y += bitsperlong.h
>  generic-y += bug.h
>  generic-y += bugs.h


Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)