linux-kernel - Re: [PATCH 3/5] OpenRISC: Export memory_start and memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1330671102.19557.100.camel@satguru>
Date:	Fri, 02 Mar 2012 07:51:42 +0100
From:	Jonas Bonn <jonas@...thpole.se>
To:	Richard Weinberger <richard@....at>
Cc:	linux@...ts.openrisc.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] OpenRISC: Export memory_start and memory_end

On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
> At least virt_addr_valid() makes use of memory_end.

virt_addr_valid looks broken... it shouldn't be comparing a virtual
address against memory_end which is phys_addr_t.

/Jonas

> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  arch/openrisc/include/asm/page.h |    4 ++--
>  arch/openrisc/kernel/setup.c     |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/openrisc/include/asm/page.h b/arch/openrisc/include/asm/page.h
> index b041b34..4dfe477 100644
> --- a/arch/openrisc/include/asm/page.h
> +++ b/arch/openrisc/include/asm/page.h
> @@ -71,8 +71,8 @@ typedef struct page *pgtable_t;
>  #define __pgd(x)	((pgd_t) { (x) })
>  #define __pgprot(x)	((pgprot_t) { (x) })
>  
> -extern unsigned long memory_start;
> -extern unsigned long memory_end;
> +extern phys_addr_t memory_start;
> +extern phys_addr_t memory_end;
>  
>  #endif /* !__ASSEMBLY__ */
>  
> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
> index bf5eba2..c993c92 100644
> --- a/arch/openrisc/kernel/setup.c
> +++ b/arch/openrisc/kernel/setup.c
> @@ -52,6 +52,7 @@
>  #include "vmlinux.h"
>  
>  char __initdata cmd_line[COMMAND_LINE_SIZE] = CONFIG_CMDLINE;
> +phys_addr_t memory_start, memory_end;
>  
>  static unsigned long __init setup_memory(void)
>  {
> @@ -59,7 +60,6 @@ static unsigned long __init setup_memory(void)
>  	unsigned long ram_start_pfn;
>  	unsigned long free_ram_start_pfn;
>  	unsigned long ram_end_pfn;
> -	phys_addr_t memory_start, memory_end;
>  	struct memblock_region *region;
>  
>  	memory_end = memory_start = 0;


Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)