linux-kernel - Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B946A444-73EC-4A70-AA7E-31FAF31FFF13@kernel.crashing.org>
Date:	Tue, 6 Mar 2012 11:46:20 -0600
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Liu Gang <Gang.Liu@...escale.com>
Cc:	<linuxppc-dev@...ts.ozlabs.org>, <Alexandre.Bounine@....com>,
	<akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
	<r58472@...escale.com>, <r61911@...escale.com>,
	Shaohui Xie <Shaohui.Xie@...escale.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit


On Mar 5, 2012, at 8:20 AM, Liu Gang wrote:

> Hi, Kumar,
> 
> On Fri, 2012-03-02 at 09:11 -0600, Kumar Gala wrote:
>>> diff --git a/arch/powerpc/sysdev/fsl_rmu.c b/arch/powerpc/sysdev/fsl_rmu.c
>>> index 1548578..468011e 100644
>>> --- a/arch/powerpc/sysdev/fsl_rmu.c
>>> +++ b/arch/powerpc/sysdev/fsl_rmu.c
>>> @@ -311,8 +311,8 @@ fsl_rio_dbell_handler(int irq, void *dev_instance)
>>> 
>>> 	/* XXX Need to check/dispatch until queue empty */
>>> 	if (dsr & DOORBELL_DSR_DIQI) {
>>> -		u32 dmsg =
>>> -			(u32) fsl_dbell->dbell_ring.virt +
>>> +		unsigned long dmsg =
>>> +			(unsigned long) fsl_dbell->dbell_ring.virt +
>>> 			(in_be32(&fsl_dbell->dbell_regs->dqdpar) & 0xfff);

How about a struct instead:

struct rmu_dmsg {
	u16	dummy;
	u16	tid;
	u16	sid;
	u16	info;
};

	struct rmu_dmsg *dmsg = fsl_dbell->dbell_ring.virt + (in_be32(&fsl_dbell->dbell_regs->dqdpar) & 0xfff);

Than you can git rid of the DBELL_* macros.


- k

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/