lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1331124741.23420.140.camel@10.ap.freescale.net>
Date:	Wed, 7 Mar 2012 20:52:21 +0800
From:	Liu Gang <Gang.Liu@...escale.com>
To:	Kumar Gala <galak@...nel.crashing.org>
CC:	<linuxppc-dev@...ts.ozlabs.org>, <Alexandre.Bounine@....com>,
	<akpm@...ux-foundation.org>, <linux-kernel@...r.kernel.org>,
	<r58472@...escale.com>, <r61911@...escale.com>,
	Shaohui Xie <Shaohui.Xie@...escale.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH] powerpc/srio: Fix the compile errors when building
	with 64bit

Hi, Kumar,

On Tue, 2012-03-06 at 11:46 -0600, Kumar Gala wrote:
> How about a struct instead:
> 
> struct rmu_dmsg {
> 	u16	dummy;
> 	u16	tid;
> 	u16	sid;
> 	u16	info;
> };
> 
> 	struct rmu_dmsg *dmsg = fsl_dbell->dbell_ring.virt + (in_be32(&fsl_dbell->dbell_regs->dqdpar) & 0xfff);
> 
> Than you can git rid of the DBELL_* macros.

Yes, this can really git rid of the DBELL_* macros and some other code.
I'll update the patch based on your comments.
Thanks a lot.

Liu Gang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ