linux-kernel - Re: [PATCH v3] sound/soc/lapis: add platform driver for ML7213

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Mar 2012 11:46:32 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH v3] sound/soc/lapis: add platform driver for ML7213

On Wed, Mar 07, 2012 at 10:30:05AM +0900, Tomoya MORINAGA wrote:
> On Tue, Mar 6, 2012 at 8:52 PM, Mark Brown

> >> if these platform devices aren't used, device detection doesn't work correctly.
> >> So, I added these.

> > You've not actually mentioned the problem you were seeing...

> I saw mapping problem between machine driver and platform driver.
> e.g.  cpu_dai_name "ml7213ioh"

You've still not explained the problem you're seeing but this sounds
like something that should work.  Please address the

> > Apart from anything else you've got the interrupt requested as
> > IRQF_SHARED so the interrupt could get called at any time.  It's also
> > not clear that you've got the hardware in a known good state.

> Do you mean request_irq should move to somewhere, like open() or
> hw_params() or ... ?

You need to do enough hardware and software initialisation prior to
requesting the interrupt to ensure that if an interrupt does happen it
won't cause any ill effects.  Checks in the interrupt handler to make
sure things like the ALSA layer stuff have been set up can also be used
to make the interrupt handler safer.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)