linux-kernel - Re: [PATCH -v2] mm: SLAB Out-of-memory diagnostics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120307144643.GB2009@x61.redhat.com>
Date:	Wed, 7 Mar 2012 11:46:44 -0300
From:	Rafael Aquini <aquini@...hat.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Cong Wang <xiyou.wangcong@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...otime.net>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Pekka Enberg <penberg@...nel.org>,
	Matt Mackall <mpm@...enic.com>, Rik van Riel <riel@...hat.com>,
	Josef Bacik <josef@...hat.com>
Subject: Re: [PATCH -v2] mm: SLAB Out-of-memory diagnostics

On Tue, Mar 06, 2012 at 09:42:57PM -0800, David Rientjes wrote:
> On Wed, 7 Mar 2012, Cong Wang wrote:
> 
> > > Following the example at mm/slub.c, add out-of-memory diagnostics to the
> > > SLAB allocator to help on debugging certain OOM conditions.
> > > 
> > > An example print out looks like this:
> > > 
> > >    <snip page allocator out-of-memory message>
> > >    SLAB: Unable to allocate memory on node 0 (gfp=0x11200)
> > >       cache: bio-0, object size: 192, order: 0
> > >       node0: slabs: 3/3, objs: 60/60, free: 0
> > > 
> > 
> > Nitpick:
> > 
> > What about "node: 0" instead of "node0: " ?
> > 
> 
> Good catch, that format would match the output of the slub out-of-memory 
> messages.
>

To be honest, I really don't see a big advantage on the nitpick, however, if we
want to accurately copycat the slub output here, I can insert a blank space
between the word and the digit, like the following:
   "node #: ..."

  Rafael 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/