linux-kernel - Re: [PATCH -v2] mm: SLAB Out-of-memory diagnostics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOJsxLFQjV1c7nQZMA2voybN0AdhGrKFN5svQHC2C=oP3vOD4g@mail.gmail.com>
Date:	Fri, 9 Mar 2012 21:41:21 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	Rafael Aquini <aquini@...hat.com>
Cc:	David Rientjes <rientjes@...gle.com>,
	Cong Wang <xiyou.wangcong@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Randy Dunlap <rdunlap@...otime.net>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Matt Mackall <mpm@...enic.com>, Rik van Riel <riel@...hat.com>,
	Josef Bacik <josef@...hat.com>
Subject: Re: [PATCH -v2] mm: SLAB Out-of-memory diagnostics

On Wed, Mar 7, 2012 at 4:46 PM, Rafael Aquini <aquini@...hat.com> wrote:
>> > Nitpick:
>> >
>> > What about "node: 0" instead of "node0: " ?
>> >
>>
>> Good catch, that format would match the output of the slub out-of-memory
>> messages.
>>
>
> To be honest, I really don't see a big advantage on the nitpick, however, if we
> want to accurately copycat the slub output here, I can insert a blank space
> between the word and the digit, like the following:
>   "node #: ..."

So if you're interested in getting this patch to v3.4, now would be a
good time to update the patch as per review comments and resend.

                        Pekka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/