linux-kernel - Re: [PATCH] perf: Incorrect use of snprintf results in SEGV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1331153964.11248.362.camel@twins>
Date:	Wed, 07 Mar 2012 21:59:24 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Peter Seebach <peter.seebach@...driver.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Anton Blanchard <anton@...ba.org>, paulus@...ba.org,
	dsahern@...il.com, fweisbec@...il.com,
	yanmin_zhang@...ux.intel.com, emunson@...bm.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: Incorrect use of snprintf results in SEGV

On Wed, 2012-03-07 at 21:37 +0100, Ingo Molnar wrote:
>         size_needed = snprintf_size(...);

This would require 3 passes over the fmt+args, first to find the
allocated size is insufficient, 2nd to compute the size, 3rd to fill
buffer.

Whereas with the current "creative" API only 2 passes are needed.

I can imagine that back in the day of small memory and small CPU this
was deemed important enough.

Anyway, its all moot, this API exists and has been out in the wild for
several decades now, its not like we can actually change it :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/