linux-kernel - Re: [PATCH v3] sound/soc/lapis: add platform driver for ML7213

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120308110548.GG3638@opensource.wolfsonmicro.com>
Date:	Thu, 8 Mar 2012 11:05:49 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH v3] sound/soc/lapis: add platform driver for ML7213

On Thu, Mar 08, 2012 at 11:06:47AM +0900, Tomoya MORINAGA wrote:
> On Wed, Mar 7, 2012 at 8:46 PM, Mark Brown

> > You've still not explained the problem you're seeing but this sounds
> > like something that should work.  Please address the

> * Faced problem if there are no platform settings.
> machine driver's hw_params is not called
> platform_driver's functions(snd_pcm_ops, snd_soc_platform_driver) are
> not called.

> As a result, the following message is not showed . (by soc_pcm.c)
> printk(KERN_INFO "asoc: %s <-> %s mapping ok\n", codec_dai->name,
>          cpu_dai->name);

This makes no sense.  Registering a platform device will have *no*
impact on ASoC, it only cares if the relevant ASoC function drivers have
come up.  Probably there was some other problem with what you were doing
but it's hard to say...

> I can understand your concern.
> Let me clarify your think.
> You think that interrupt handler must check whether ALSA initialization has
> already finished or not before interrupt process executes.
> Right?

Or it should be safe to run even in the card has not come up yet, either
way is fine.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)