linux-kernel - Re: [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANKRQnh2JqhZBYLP=U_isgthh2pFT89_qBeypda1ciUJzoRXYw@mail.gmail.com>
Date:	Thu, 8 Mar 2012 11:24:36 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com, kok.howg.ewe@...el.com
Subject: Re: [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124

On Wed, Mar 7, 2012 at 8:48 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
>> If possible, I want to use framework features. However, I judged it is
>> not possible.
>> Let me confirm again.
>> As I said before, all ML26124 registers need to be accessed by
>> different address when read and write.
>> Like below
>> R       W
>> $00h $01h Sampling setting
>> $02h $03h PLL setting
>> ...
>> Even so, can I use framework features ?
> No, in which case (to repeat what I said previously) you need to make
> the code *much* clearer so the reader can understand what it is doing
> and why it's having to open code this stuff.

I understand you agree to use ml26124_update_bits(), right ?
If so, do you mean that I should just add explanation (like as I
explained before)
why the function() is necessary to above prototype of ml26124_update_bits() ?

thanks.
-- 
ROHM Co., Ltd.
tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/