linux-kernel - Re: [PATCH v2 0/3] ahci: fix boot/resume COMRESET failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE5mzviyg1L3HhSy4gYeLv673GN3M6JU68wwhzNBTKp6dtxTBg@mail.gmail.com>
Date:	Fri, 9 Mar 2012 10:07:41 -0600
From:	cwillu <cwillu@...llu.com>
To:	Lin Ming <ming.m.lin@...el.com>
Cc:	Brian Norris <computersforpeace@...il.com>,
	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Tejun Heo <tj@...nel.org>,
	Norbert Preining <preining@...ic.at>,
	"Srivatsa S . Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Matt <jackdachef@...il.com>
Subject: Re: [PATCH v2 0/3] ahci: fix boot/resume COMRESET failures

>>>> I just spent the better part of last night tracking down the specific
>>>> sources of the log entry I get when I disconnect my e-sata drive; once
>>>> it disconnects, the port is dead until I reboot; no combination of
>>>> anything I've been able to poke at in /sys or elsewhere gets it live
>>>> again.  This starts with 3.3rc1, and turns out to still work fine in
>>>> 3.2.1. Any chance it's related?
>>>>
>>>> 3.3rc5, immediately after the unplug:
>>>
>>> I tested on my machine and it's fixed by below patch.
>>> http://marc.info/?l=linux-kernel&m=132996405028746&w=2
>>>
>>> Would you please also try it?
>>
>> Building it now, and will be able to test in about 5 hours.
>
> Hi,
>
> How about the test result?

Sorry about the delay.

Just verified, that patch does fix the problem:

*disconnect drive*
[   80.474026] ata5: exception Emask 0x50 SAct 0x0 SErr 0x4090800
action 0xe frozen
[   80.474041] ata5: irq_stat 0x00400040, connection status changed
[   80.474057] ata5: SError: { HostInt PHYRdyChg 10B8B DevExch }
[   80.474064] ata5: hard resetting link
[   81.197080] ata5: SATA link down (SStatus 0 SControl 300)
[   86.197028] ata5: hard resetting link
[   86.502021] ata5: SATA link down (SStatus 0 SControl 300)
[   86.502039] ata5: limiting SATA link speed to 1.5 Gbps
[   91.502018] ata5: hard resetting link
[   91.807032] ata5: SATA link down (SStatus 0 SControl 310)
[   91.807050] ata5.00: disabled
[   91.807069] ata5: EH complete
[   91.807095] ata5.00: detaching (SCSI 4:0:0:0)
[   91.808988] sd 4:0:0:0: [sde] Synchronizing SCSI cache
[   91.810288] sd 4:0:0:0: [sde]  Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK
[   91.810305] sd 4:0:0:0: [sde] Stopping disk
[   91.810318] sd 4:0:0:0: [sde] START_STOP FAILED
[   91.810333] sd 4:0:0:0: [sde]  Result: hostbyte=DID_BAD_TARGET
driverbyte=DRIVER_OK
[  106.507666] ata5: exception Emask 0x10 SAct 0x0 SErr 0x4040000
action 0xe frozen
[  106.507683] ata5: irq_stat 0x00000040, connection status changed
[  106.507703] ata5: SError: { CommWake DevExch }
[  106.507710] ata5: limiting SATA link speed to 1.5 Gbps
[  106.507715] ata5: hard resetting link
*reconnect drive*
[  107.386022] ata5: SATA link up 1.5 Gbps (SStatus 113 SControl 310)
[  107.387979] ata5.00: ATA-8: WDC WD10EARS-00Y5B1, 80.00A80, max UDMA/133
[  107.387985] ata5.00: 1953525168 sectors, multi 16: LBA48 NCQ (depth
31/32), AA
[  107.389253] ata5.00: configured for UDMA/133
[  107.389264] ata5: EH complete
[  107.389375] scsi 4:0:0:0: Direct-Access     ATA      WDC
WD10EARS-00Y 80.0 PQ: 0 ANSI: 5
[  107.389551] sd 4:0:0:0: [sde] 1953525168 512-byte logical blocks:
(1.00 TB/931 GiB)
[  107.389613] sd 4:0:0:0: [sde] Write Protect is off
[  107.389619] sd 4:0:0:0: [sde] Mode Sense: 00 3a 00 00
[  107.389651] sd 4:0:0:0: [sde] Write cache: enabled, read cache:
enabled, doesn't support DPO or FUA
[  107.389667] sd 4:0:0:0: Attached scsi generic sg4 type 0
[  107.803230]  sde: unknown partition table
[  107.803550] sd 4:0:0:0: [sde] Attached SCSI disk
*rejoicing*

Thanks.

--Carey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/