linux-kernel - Re: [PATCH v2 0/3] ahci: fix boot/resume COMRESET failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Mar 2012 01:07:07 +0100
From:	Matt <jackdachef@...il.com>
To:	Lin Ming <ming.m.lin@...el.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	viro@...iv.linux.org.uk, jeff@...zik.org,
	Brian Norris <computersforpeace@...il.com>,
	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	Tejun Heo <tj@...nel.org>,
	Norbert Preining <preining@...ic.at>,
	"Srivatsa S . Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2 0/3] ahci: fix boot/resume COMRESET failures

On Wed, Mar 7, 2012 at 6:28 AM, Lin Ming <ming.m.lin@...el.com> wrote:
> On Mon, Mar 5, 2012 at 1:12 PM, cwillu <cwillu@...llu.com> wrote:
>> On Sun, Mar 4, 2012 at 6:58 PM, Lin Ming <ming.m.lin@...el.com> wrote:
>>> On Fri, Mar 2, 2012 at 9:16 PM, cwillu <cwillu@...llu.com> wrote:
>>>> On Tue, Feb 21, 2012 at 12:38 PM, Brian Norris
>>>> <computersforpeace@...il.com> wrote:
>>>>> This series addresses regression problems with
>>>>>
>>>>>    commit 7faa33da9b7add01db9f1ad92c6a5d9145e940a7
>>>>>    ahci: start engine only during soft/hard resets
>>>>
>>>> I just spent the better part of last night tracking down the specific
>>>> sources of the log entry I get when I disconnect my e-sata drive; once
>>>> it disconnects, the port is dead until I reboot; no combination of
>>>> anything I've been able to poke at in /sys or elsewhere gets it live
>>>> again.  This starts with 3.3rc1, and turns out to still work fine in
>>>> 3.2.1. Any chance it's related?
>>>>
>>>> 3.3rc5, immediately after the unplug:
>>>
>>> Hi,
>>>
>>> I tested on my machine and it's fixed by below patch.
>>> http://marc.info/?l=linux-kernel&m=132996405028746&w=2
>>>
>>> Would you please also try it?
>>
>> Building it now, and will be able to test in about 5 hours.
>
> Hi,
>
> How about the test result?
>
> Regards,
> Lin Ming
>
>>
>> After looking at the thread, I spent another couple hours on poking
>> /sys, and did get the port to come back up and find the drive with the
>> following:
>>
>> echo on > /sys/devices/pci0000:00/0000:00:1f.2/ata5/power/control
>> echo on > /sys/devices/pci0000:00/0000:00:1f.2/ata5/host4/power/control
>> echo '- - -' > /sys/devices/pci0000:00/0000:00:1f.2/ata5/host4/scsi_host/host4/scan
>> --

@Carey:

thanks for the commands !


@Lin Ming:

I also have to apologize for the delay, I had much stuff to
repartition, reformat and re-sync during the week and finally
yesterday & today - after finishing that - I could do some testing

that patch works wonderfully - thanks a lot !


the system with 3.3 is significantly more responsive :)

so if there are no reservations against the patch please include it
for final and/or .1 kernel-release of 3.3



on a related note: I had one observation though (non-related to the
mentioned issue)

with or without the patch my computer doesn't turn itself off anymore,
if I remember correctly that didn't happen with rc3 (I could be wrong
though)

anyone else had the same issue ?

to not further delay the final release by this "minor" issue - I'll
test again once final is out and see whether there it's the same

and if that's the case I'll write again & provide you with further
information that you'll need


Awesome work as always, thanks !

Kind Regards

Matt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/