linux-kernel - Re: [PATCH v2 0/3] ahci: fix boot/resume COMRESET failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120312221209.GH23255@google.com>
Date:	Mon, 12 Mar 2012 15:12:09 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Lin Ming <ming.m.lin@...el.com>,
	Norbert Preining <preining@...ic.at>,
	"Srivatsa S . Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Valdis Kletnieks <valdis.kletnieks@...edu>,
	"Rafael J . Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH v2 0/3] ahci: fix boot/resume COMRESET failures

On Tue, Feb 21, 2012 at 10:38:41AM -0800, Brian Norris wrote:
> This series addresses regression problems with
> 
>     commit 7faa33da9b7add01db9f1ad92c6a5d9145e940a7
>     ahci: start engine only during soft/hard resets
> 
> Because the fix provided by the above commit caused COMRESET failures and
> 10 second boot-time/resume-time hangs for certain DVD drives, we need to
> make the fix conditional to certain devices/platforms. Add a flag for this.
> 
> Brian
> 
> v2: change flag name to AHCI_HFLAG_DELAY_ENGINE, write more detailed
>     comments
> 
> v1: flag named AHCI_HFLAG_STRICT_SPEC
> 
> Brian Norris (3):
>   ahci: add AHCI_HFLAG_DELAY_ENGINE host flag
>   ahci: move AHCI_HFLAGS() macro to ahci.h
>   ahci_platform: add STRICT_AHCI platform type

This looks good to me.  Jeff?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/