linux-kernel - Re: Re: [PATCH 0/3] power: max17042

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <17763564.55121331517212251.JavaMail.weblogic@epml04>
Date:	Mon, 12 Mar 2012 01:53:32 +0000 (GMT)
From:	함명주 <myungjoo.ham@...sung.com>
To:	Karol Lewandowski <k.lewandowsk@...sung.com>
Cc:	DirkBrandewie <dirk.brandewie@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"AntonVorontsov<cbou"@mail.ru, "DavidWoodhouse<dwmw2"@infradead.org
Subject: Re: Re: [PATCH 0/3] power: max17042_battery: Add DT bindings

Karol Lewandowski<k.lewandowsk@...sung.com>, 2012-03-10 02:32 (GMT+09:00)
> Dear MungJoo,
> 
> I wasn't aware of Dirk's patchset and thus, I didn't ever try to make my
> patches compatible with it.
> 
> I've found hopefully correct patchset[1] via google - it's mailing list
> posting without any feedback...  I've checked linux-next and it clearly
> hasn't been merged.
> 
> I'm happy to rework my patch but I would like to ask you about specific
> tree I should base on.  Is this patchset in some subsystem-specific
> (power?) tree? Other?

Dear Karol,

I preferred Dirk's patchset included because it is for the correctness of the device driver.

However, as Dirk's patchset has not been updated or merged for long, I guess you may go ahead trying to merge this DT patchset first.

It appears that this patchset does not force much trouble for Dirk's side as the two are virtually disjoint and it seems rebasing Dirk's patchset upon this patchset trivial though I didn't try that yet.

Anyway, please consider "Acked-by" from me for the patches.


Cheers!
MyungJoo.

> 
> [1] https://lkml.org/lkml/2012/1/24/237
> 
> Regards,
> -- 
> Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform
> 
> On 09.03.2012 01:16, 함명주 wrote:
> 
> > Dear Karol Lewandowski,
> > 
> > I've been confused this patchset with Dirk Brandewie's MAX17042 patchset; I though this was a follow-up version of Dirk's, which I think already acked by me.
> > 
> > Anyway, the patches themselves look fine.
> > 
> > However, have you checked the compatibility (mergability?) with the recent MAX17042 patches of Dirk Brandewie? I'm not sure about the merge status of Dirk's patchset, but, I think you need to consider his patches as they massively reshaped the device driver.
> > 
> > Other than that, the patches look fine. (If that issue is already considered, regard this as an Acked-by.)
> > 
> > Thank you.
> > 
> > 
> > Cheers!
> > MyungJoo.
> > 
> > ------- Original Message -------
> > Sender : Karol Lewandowski Junior Software Engineer/SPRC-Linux (MSD)/삼성전자
> > Date : 2012-03-08 19:32 (GMT+09:00)
> > Title : Re: [PATCH 0/3] power: max17042_battery: Add DT bindings
> > 
> > Dear MyungJoo Ham,
> > 
> > Could you take a look at patchset I've sent? It's needed to make use of
> > max17042 driver on device tree-enabled platforms.
> > 
> > Regards,
> 
> 
> 
> 
> 

--

MyungJoo Ham (함명주), PHD

System S/W Lab, S/W Platform Team, Software Center
Samsung Electronics
Cell: +82-10-6714-2858