linux-kernel - Re: [RESEND PATCH 1/2] MFD: MAX77693: add MAX77693 MFD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2012 14:39:23 +0900
From:	Kyungmin Park <kyungmin.park@...sung.com>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
Cc:	Chanwoo Choi <cw00.choi@...sung.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"myungjoo.ham@...sung.com" <myungjoo.ham@...sung.com>
Subject: Re: [RESEND PATCH 1/2] MFD: MAX77693: add MAX77693 MFD driver

Hi,

It's discussed previous time. It's PMIC and very sensitive to system.
So we decide to use legacy way. As regmap is not yet tested. So we
summit the current way and revise it later.

Thank you,
Kyungmin Park

On 3/13/12, Venu Byravarasu <vbyravarasu@...dia.com> wrote:
> Why don't you make use of regmap for all i2c read/ write operations?
>
>> +int max77693_read_reg(struct i2c_client *i2c, u8 reg, u8 *dest)
>> +{
>> +	struct max77693_dev *max77693 = i2c_get_clientdata(i2c);
>> +	int ret;
>> +
>> +	mutex_lock(&max77693->iolock);
>> +	ret = i2c_smbus_read_byte_data(i2c, reg);
>> +	mutex_unlock(&max77693->iolock);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	ret &= 0xff;
>> +	*dest = ret;
>> +	return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(max77693_read_reg);
>> +
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/