linux-kernel - suppress page allocation failure warnings from sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120313182220.GA11500@redhat.com>
Date:	Tue, 13 Mar 2012 14:22:20 -0400
From:	Dave Jones <davej@...hat.com>
To:	viro@...iv.linux.org.uk
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: suppress page allocation failure warnings from sys_listxattr

This size is user controllable, and so it's trivial for someone to trigger a
stream of order:4 page allocation errors.

Signed-off-by: Dave Jones <davej@...hat.com>

--- 
There's also a similar problem in setxattr, but I'm not sure how we want
to pass NOWARN down to memdup_user. Thoughts ?

diff --git a/fs/xattr.c b/fs/xattr.c
index 82f4337..544df90 100644
--- a/fs/xattr.c
+++ b/fs/xattr.c
@@ -496,7 +496,7 @@ listxattr(struct dentry *d, char __user *list, size_t size)
 	if (size) {
 		if (size > XATTR_LIST_MAX)
 			size = XATTR_LIST_MAX;
-		klist = kmalloc(size, GFP_KERNEL);
+		klist = kmalloc(size, __GFP_NOWARN | GFP_KERNEL);
 		if (!klist)
 			return -ENOMEM;
 	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/