linux-kernel - Re: suppress page allocation failure warnings from sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2012 17:33:55 -0400
From:	Colin Walters <walters@...bum.org>
To:	Dave Jones <davej@...hat.com>
Cc:	viro@...iv.linux.org.uk,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: suppress page allocation failure warnings from sys_listxattr

On Tue, 2012-03-13 at 14:22 -0400, Dave Jones wrote:
> This size is user controllable, and so it's trivial for someone to trigger a
> stream of order:4 page allocation errors.

I spent some time today struggling with an order:4 allocation failure
(my application uses CLONE_NEWNET to make an empty network stack for
software builds, and apparently one of the netfilter caches requires
this).

But is that the general principle, that we just add GFP_NOWARN if the
allocation size is trivially user controllable?  I guess examples like
fs/pipe.c:pipe_set_size() agree with you, but it feels kind of like
it's papering over the problem...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/