linux-kernel - Re: [PATCH] Staging: rtl8187se: r8180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Mar 2012 19:54:02 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Andrew Miller <amiller@...lx.com>
Cc:	Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: r8180_core.c: Fix coding style issue

On Tue, Mar 13, 2012 at 10:33:42PM -0400, Andrew Miller wrote:
> Thanks, you help me alot
> 
> If you don't mind me asking a few more question.
> 
> Would fixing things like this
> 
> - if(x==y)
> + if(x == y)
> 
> be worthless? 

Yes, as it should really be:
	if (x == y)
:)

> Changing c++ style comment to c style? 

That's also good.

> And I should not wory about line being longer the 80 charactor, unless they are
> just extremely long?

If you feel it will read better, than yes, do it.

> I'm just over half way through my CS degree, so I'm a complete noob.
> I'm still learning what is not worth spending time on and what is.

This is worthwhile, if you want to do this.  Cleanups like this are a
great place to learn and get involved and become comfortable with the
codebase.

Just don't mix different fixes in the same patch.

And don't top post :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/