linux-kernel - Re: [PATCH] Staging: rtl8187se: r8180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F600BF3.2080001@lwfinger.net>
Date:	Tue, 13 Mar 2012 22:09:39 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Joe Perches <joe@...ches.com>
CC:	Andrew Miller <amiller@...lx.com>, gregkh@...uxfoundation.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: r8180_core.c: Fix coding style issue

On 03/13/2012 09:46 PM, Joe Perches wrote:
> On Tue, 2012-03-13 at 22:33 -0400, Andrew Miller wrote:
>> Thanks, you help me alot
>>
>> If you don't mind me asking a few more question.
>>
>> Would fixing things like this
>>
>> - if(x==y)
>> + if(x == y)
>>
>> be worthless?
>
> I don't work on staging code.
>
> I believe the staging rtl8187se directory could be
> deleted as there is a working mainline directory
> for the 8187 (drivers/net/wireless/rtl818x/rtl8187)
> so you may not actually be adding anything of value.
>
> I don't know if the 8187se is supported by the 8187
> code but likely Larry Finger (cc'd) knows better.

Driver rtl8187 handles USB devices - the RTL8187SE is PCI based - thus separate 
drivers are needed. I have done a lot of the conversion of a mac80211-based 
driver for the RTL8187SE, but ran into a problem where it could transmit small 
packets, but fail completely for longer ones. While trying to fix that, I needed 
to work on devices that had no Linux driver, and I have not gotten back to it.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/