[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAM=Q2cssNF2TSWHjcbG4wsABBXhquYoKq_scC6bDcq8kdoosyQ@mail.gmail.com>
Date: Thu, 15 Mar 2012 19:10:42 +0530
From: Shubhrajyoti Datta <omaplinuxkernel@...il.com>
To: Marc Reilly <marc@...esign.com.au>
Cc: sameo@...ux.intel.com, linux-arm-kernel@...ts.infradead.org,
broonie@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
linux-i2c@...r.kernel.org, u.kleine-koenig@...gutronix.de,
spi-devel-general@...ts.sourceforge.net, oskar@...ra.com
Subject: Re: [PATCH v3 6/6] mfd: mc13xxx: Add i2c driver
Hi Marc,
On Thu, Mar 15, 2012 at 2:13 AM, Marc Reilly <marc@...esign.com.au> wrote:
> Adds support for mc13xxx family ICs connected via i2c.
>
> Signed-off-by: Marc Reilly <marc@...esign.com.au>
> ---
<snip>
> +static int mc13xxx_i2c_probe(struct i2c_client *client,
> + const struct i2c_device_id *id)
> +{
> + const struct of_device_id *of_id;
> + struct i2c_driver *idrv = to_i2c_driver(client->dev.driver);
> + struct mc13xxx *mc13xxx;
> + struct mc13xxx_platform_data *pdata = dev_get_platdata(&client->dev);
> + int ret;
> +
> + of_id = of_match_device(mc13xxx_dt_ids, &client->dev);
> + if (of_id)
> + idrv->id_table =
> + &mc13xxx_i2c_device_id[(enum mc13xxx_id) of_id->data];
> +
> + mc13xxx = kzalloc(sizeof(*mc13xxx), GFP_KERNEL);
> + if (!mc13xxx)
> + return -ENOMEM;
> +
> + dev_set_drvdata(&client->dev, mc13xxx);
> +
> + mc13xxx->dev = &client->dev;
> + mutex_init(&mc13xxx->lock);
> +
> + mc13xxx->regmap = regmap_init_i2c(client, &mc13xxx_regmap_i2c_config);
> + if (IS_ERR(mc13xxx->regmap)) {
> + ret = PTR_ERR(mc13xxx->regmap);
> + dev_err(mc13xxx->dev, "Failed to initialize register map: %d\n",
> + ret);
> + dev_set_drvdata(&client->dev, NULL);
Are we leaking mc13xxx here
May be you can consider using devm* functions ?
> + return ret;
> + }
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists