linux-kernel - Re: [PATCH v3 4/6] mfd: mc13xxx-core: use regmap for register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120315174343.GQ3138@opensource.wolfsonmicro.com>
Date:	Thu, 15 Mar 2012 17:43:44 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Marc Reilly <marc@...esign.com.au>
Cc:	sameo@...ux.intel.com, linux-arm-kernel@...ts.infradead.org,
	spi-devel-general@...ts.sourceforge.net, linux-i2c@...r.kernel.org,
	u.kleine-koenig@...gutronix.de, oskar@...ra.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/6] mfd: mc13xxx-core: use regmap for register access

On Thu, Mar 15, 2012 at 07:43:08AM +1100, Marc Reilly wrote:
> This change converts the mc13xxx core to use regmap rather than direct
> spi r/w.
> The spidev member of mc13xxx struct becomes redundant and is removed.
> Extra debugging aids are added to mc13xxx_reg_rmw.
> Mutex init is moved to before regmap init.

Reviwed-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

For rmw please push the trace down into regmap as a new tracepoint if
you find it useful; one of the wins from regmap is intended to be the
trace and diagnostic infrastructure you get for free with it.  At the
minute only the underlying reads and writes have trace.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)