linux-kernel - Re: [PATCH] usb/xhci: unify parameter of xhci_msi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Mar 2012 10:56:08 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	Alex Shi <alex.shi@...el.com>
Cc:	gregkh <gregkh@...uxfoundation.org>,
	"Sharp, Sarah A" <sarah.a.sharp@...el.com>,
	Alan stern <stern@...land.harvard.edu>,
	Felipe Balbi <balbi@...com>,
	linux-usb <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb/xhci: unify parameter of xhci_msi_irq

On Thu, Mar 15, 2012 at 11:03:19PM +0800, Alex Shi wrote:
> On 03/15/2012 10:57 PM, gregkh wrote:
> 
> > On Thu, Mar 15, 2012 at 12:53:06PM +0800, Alex Shi wrote:
> >>
> >> According to Felipe and Alan's comments the second parameter of irq
> >> handler should be 'void *' not a specific structure pointer. 
> >> So change it.
> >>
> >> Signed-off-by: Alex Shi <alex.shi@...el.com>
> >> ---
> >>  drivers/usb/host/xhci-ring.c |    2 +-
> >>  drivers/usb/host/xhci.c      |    4 ++--
> >>  drivers/usb/host/xhci.h      |    2 +-
> >>  3 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > Is this needed in my -next tree now?  Or is it something for later?
> 
> 
> Appreciate if it can be in -next tree. :)
> 
> > 
> > Any reason you did not put Sarah on the To: line here?  She's the one
> > that needs to ack it before I can accept it.
> 
> 
> Sarah, would you like to give some comments here?

Looks fine.  I'll send a pull request to Greg with this patch after I
verify it doesn't generate new warnings.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/