linux-kernel - Re: [PATCH] usb/ub: deprecate & schedule for removal the "Low Performance USB Block" driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120315175701.GA5702@breakpoint.cc>
Date:	Thu, 15 Mar 2012 18:57:01 +0100
From:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
To:	Pete Zaitcev <zaitcev@...hat.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb/ub: deprecate & schedule for removal the "Low
 Performance USB Block" driver

On Thu, Mar 15, 2012 at 09:33:31AM -0600, Pete Zaitcev wrote:
> On Wed, 14 Mar 2012 21:52:51 +0100
> Sebastian Andrzej Siewior <sebastian@...akpoint.cc> wrote:
> 
> > +What:	Low Performance USB Block driver ("CONFIG_BLK_DEV_UB")
> > +When:	3.6
> 
> ACK
> 
> > +	does not use libusual which holds various workarounds for
> > +	certain buggy devices.
> 
> Although the above is false, and ub actually started libusual,
> I don't mind. It's a transient notice anyway. Once ub is gone,
> libusual can be folded back into usb-storage.

There might be an miss understanding here. For instance in
drivers/usb/storage/unusual_devs.h we have an entry like:

|UNUSUAL_DEV(  0x03f0, 0x4002, 0x0001, 0x0001,
|                 "HP",
|                 "PhotoSmart R707",
|                 USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_FIX_CAPACITY),
|

That US_FL_FIX_CAPACITY is used later in scsiglue.c to set sdev->fix_capacity
which is then used by sd_read_capacity() to substract one sector from the
final size.
In ub I see ub_sync_read_cap() and I don't see a change. Was my wording wrong
or is this something else?

> -- Pete

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/