linux-kernel - Re: [PATCH 5/5] Staging: rtl8187se: r8180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Mar 2012 16:49:23 -0400
From:	Andrew Miller <amiller@...lx.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] Staging: rtl8187se: r8180_dm.c: Fix comments

On Thu, Mar 15, 2012 at 10:34:05PM +0300, Dan Carpenter wrote:
> On Thu, Mar 15, 2012 at 03:05:21PM -0400, Andrew Miller wrote:
> > -//+by amy 080312
> > +/*{by amy 080312 */
>       ^^^^^^^^^^^^^
> Just remove these comments.  We use version control to see who is
> doing what.
> 
> >  
> > -	//printk("----> DoTxHighPower()\n");
> > +	/* printk("----> DoTxHighPower()\n"); */
> >  
> 
> Also this dead debugging code can be deleted.  There was a bunch of
> it.
> 
> regards,
> dan carpenter

Thanks for the advice, If the patch goes through. I'll make another one 
with this changes. If not then I will include them when I revise it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/