linux-kernel - Re: [PATCH] power, max8998: Include linux/module.h just once in drivers/power/max8998

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1203152153530.18680@swampdragon.chaosbits.net>
Date:	Thu, 15 Mar 2012 21:54:13 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	ÇÔ¸íÁÖ <myungjoo.ham@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"trivial@...nel.org" <trivial@...nel.org>,
	Axel Lin <axel.lin@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] power, max8998: Include linux/module.h just once in
 drivers/power/max8998_charger.c

On Thu, 15 Mar 2012, Paul Gortmaker wrote:

> On 12-03-15 01:17 PM, Anton Vorontsov wrote:
> > On Mon, Feb 06, 2012 at 01:57:54AM +0000, í•¨ëª…ì£¼ wrote:
> >>> Remove the duplicate.
> >>>
> >>> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> >>
> >> Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>
> > 
> > Applied, thanks!
> 
> There is already a commit queued in linux-next that deletes
> all the duplicates at once.  It just so happens to delete
> the other instance vs the one shown here.  So if both
> commits are present, then there won't be *any* module.h
> left, and the build will fail.  If it is possible, please
> just drop this patch, since the treewide duplicate patch
> will still have to exist to fix the other instances.
> 
> https://lkml.org/lkml/2012/2/29/586
> 

I agree. Drop this one.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.