linux-kernel - Re: [PATCH 1/4] fs: Remove bogus wait in write_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120319065739.GA11113@infradead.org>
Date:	Mon, 19 Mar 2012 02:57:39 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Jan Kara <jack@...e.cz>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/4] fs: Remove bogus wait in write_inode_now()

On Fri, Mar 09, 2012 at 10:02:25AM +0100, Jan Kara wrote:
> inode_sync_wait() in write_inode_now() is just bogus. That function waits for
> I_SYNC bit to be cleared but writeback_single_inode() clears the bit on return
> so the wait is effectivelly a nop unless someone else submits the inode for
> writeback again. All the waiting write_inode_now() needs is achieved by using
> WB_SYNC_ALL writeback mode.
> 
> Signed-off-by: Jan Kara <jack@...e.cz>

Loks good - I have the same in my patchkit to kill write_inode_now
(which I really need to get out soon).

Signed-off-by: Christoph Hellwig <hch@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/