linux-kernel - Re: [PATCH 0/4] Get rid of iput() from flusher thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120319051636.GB5191@localhost>
Date:	Mon, 19 Mar 2012 13:16:36 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-fsdevel@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 0/4] Get rid of iput() from flusher thread

On Fri, Mar 09, 2012 at 10:02:24AM +0100, Jan Kara wrote:
> 
>   Hi,
> 
>   this patch set changes writeback_sb_inodes() to avoid iput() which might
> be problematic (see patch 4 which tries to summarize our email discussions)
> for some filesystems.
> 
>   Patches 1 and 2 are trivial mostly unrelated fixes (Fengguang, can you can
> take these and merge them right away please?).

Sure, they have been tested in linux-next for some days.

> Patch 3 is a preparatory code
> reshuffle and patch 4 removes the __iget() / iput() from flusher thread.

These are pretty sane changes towards the right direction (in despite
of the complexities involved).

>   As a side note, your patches to offload writeback from kswapd to flusher
> thread then won't need iget/iput either if we pass page references as we talked
> so that should resolve most of the concerns.
> 
>   What do you think guys?

I appreciate the work a lot. Thank you for removing the major problem
with the patches on pageout writeback work :-)

Regards,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/