linux-kernel - readd back NOVATELWIRELESS_PRODUCT_HSPA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Mar 2012 11:21:54 +0100
From:	Santiago Garcia Mantinan <manty@...ian.org>
To:	linux-kernel@...r.kernel.org
Cc:	664605@...s.debian.org
Subject: readd back NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED to option.c
 [patch]

Hi!

It looks like there was a mistake on Dirk De Schepper's patch commited by
gregkh on 4 Sep 2010 00:33:40 +0000 which can be seen here:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c7aa8f44b4d1dc73591894a2dd6909213612d299

He removed NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED from the scruct while
moving things around, it was a bit difficult to see as the defines and the
struct are not on the same order.  We've carried this for a year and a half
and for what I've seen there have been some reports about this like:
https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/750362
but unfortunately it didn't get much attention.

I've looked at the strings and the only one missing was
NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED, so here is the patch for it.

--- option.c.old	2012-03-19 10:16:31.046565765 +0100
+++ option.c	2012-03-19 10:55:34.348846327 +0100
@@ -538,6 +538,7 @@
 	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_EVDO_EMBEDDED_FULLSPEED) },
 	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_EMBEDDED_FULLSPEED) },
 	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_EVDO_HIGHSPEED) },
+	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED) },
 	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED3) },
 	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED4) },
 	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED5) },

Regards.
-- 
Manty/BestiaTester -> http://manty.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/