lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Mar 2012 10:08:01 -0500 From: Jonathan Nieder <jrnieder@...il.com> To: Santiago Garcia Mantinan <manty@...ian.org> Cc: linux-kernel@...r.kernel.org, Matthias Urlichs <smurf@...rf.noris.de>, linux-usb@...r.kernel.org, Dirk De Schepper <ddeschepper@...l.com> Subject: Re: [PATCH] USB: option: re-add NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED to option_id array (cc-ing some relevant people) Hi, Santiago Garcia Mantinan wrote: > c7aa8f44b4d1dc73591894a2dd6909213612d299 [...] > removed NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED from the scruct while > moving things around, it was a bit difficult to see as the defines and the > struct are not on the same order. We've carried this for a year and a half > and for what I've seen there have been some reports about this like: > https://bugs.launchpad.net/ubuntu/+source/usb-modeswitch/+bug/750362 > but unfortunately it didn't get much attention. > > I've looked at the strings and the only one missing was > NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED, so here is the patch for it. Thanks! Can we have your sign-off? See Documentation/SubmittingPatches, item 12 "Sign your work", for what this means. > --- option.c.old 2012-03-19 10:16:31.046565765 +0100 > +++ option.c 2012-03-19 10:55:34.348846327 +0100 > @@ -538,6 +538,7 @@ > { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_EVDO_EMBEDDED_FULLSPEED) }, > { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_EMBEDDED_FULLSPEED) }, > { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_EVDO_HIGHSPEED) }, > + { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED) }, > { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED3) }, > { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED4) }, > { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_HSPA_HIGHSPEED5) }, Hope that helps, Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists