linux-kernel - Re: [ 05/38] PCI: ignore pre-1.1 ASPM quirking when ASPM is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120319162516.GA3694@kroah.com>
Date:	Mon, 19 Mar 2012 09:25:16 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jonathan Nieder <jrnieder@...il.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, alan@...rguk.ukuu.org.uk,
	Matthew Garrett <mjg@...hat.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>, romain@...bokech.com,
	Jiri Slaby <jirislaby@...il.com>
Subject: Re: [ 05/38] PCI: ignore pre-1.1 ASPM quirking when ASPM is disabled

On Mon, Mar 19, 2012 at 11:04:16AM -0500, Jonathan Nieder wrote:
> Greg KH wrote:
> > On Mon, Mar 19, 2012 at 11:20:34AM +0100, Jiri Slaby wrote:
> 
> >> The commit below is reported to crash the machine in the early init. See
> >> the first reply to this message (lkml.org seems to be down right now):
> >> lkml.org/lkml/2012/3/18/132
> >
> > Yes, but this patch fixes machines that others have been reporting
> > problems with, so, what am I supposed to do?
> >
> > I'll stick with this patch for now, and hope that Matthew fixes this up
> > in Linus's tree and I'll suck that fix in when it gets there.  Is that
> > ok?
> 
> Just one data point from a distro perspective: regressions are way
> more painful than problems that already existed.  So it seems worth
> considering dropping the patch for now and grabbing the patch and fix
> when ready.

I think you are missing the fact that this patch itself is fixing a
regression from a previous patch :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/