linux-kernel - Re: [PATCH v7] sound/soc/lapis: add machine driver for ML7213 Carrier Board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120319192101.GG12384@opensource.wolfsonmicro.com>
Date:	Mon, 19 Mar 2012 19:21:01 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tomoya MORINAGA <tomoya.rohm@...il.com>
Cc:	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>, lars@...afoo.de,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com
Subject: Re: [PATCH v7] sound/soc/lapis: add machine driver for ML7213
 Carrier Board

On Mon, Mar 19, 2012 at 09:02:05PM +0900, Tomoya MORINAGA wrote:

> +static int ml7213_hw_params(struct snd_pcm_substream *substream,
> +			    struct snd_pcm_hw_params *hw_params)
> +{

> +	default:
> +		pr_err("%s: Failed not support format\n", __func__);
> +		return -EINVAL;
> +		break;

No need for the break.

> +	snd_soc_dapm_enable_pin(dapm, "Speaker");
> +	snd_soc_dapm_enable_pin(dapm, "AnalogMIC");
> +	snd_soc_dapm_enable_pin(dapm, "MICBIAS");

Why are you doing thiS?  You never disable these things so if this were
needed you may as well do it on init, but since the default state is
enabled anyway this shouldn't be doing anytihng.

> +static int __init lapis_ml7213_ml26124_init(void)
> +{
> +	return platform_driver_register(&snd_ml7213crb_driver);
> +}
> +module_init(lapis_ml7213_ml26124_init);

module_platform_driver().

> +MODULE_ALIAS("platform: lapis-ml7213ioh-CRB");

No space after the colon.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)