linux-kernel - Re: [PATCH v7] sound/soc/lapis: add machine driver for ML7213 Carrier Board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANKRQniytxNLHdkCDF5W4ZZHxo7w5WJgtYh1036x7DNBe4h2ZA@mail.gmail.com>
Date:	Wed, 21 Mar 2012 09:51:58 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Liam Girdwood <lrg@...com>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.de>, lars@...afoo.de,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	qi.wang@...el.com, yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com
Subject: Re: [PATCH v7] sound/soc/lapis: add machine driver for ML7213 Carrier Board

On Tue, Mar 20, 2012 at 4:21 AM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
>> +     snd_soc_dapm_enable_pin(dapm, "Speaker");
>> +     snd_soc_dapm_enable_pin(dapm, "AnalogMIC");
>> +     snd_soc_dapm_enable_pin(dapm, "MICBIAS");
>
> Why are you doing thiS?  You never disable these things so if this were
> needed you may as well do it on init, but since the default state is
> enabled anyway this shouldn't be doing anytihng.

OK.
I've confirmed if deleting these lines, both playback/capture work well.
So, I'll delete these.

thanks.
-- 
ROHM Co., Ltd.
tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/