linux-kernel - possible bug (or not clear coding) in uvc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120320160251.GA79846@mail.kolej.mff.cuni.cz>
Date:	Tue, 20 Mar 2012 17:02:51 +0100
From:	Jozef Vesely <vesely@....sk>
To:	linux-kernel@...r.kernel.org
Cc:	laurent.pinchart@...asonboard.com
Subject: possible bug (or not clear coding) in uvc_v4l2.c

Good day, 

I am sorry to disturb you, I have been reading through uvc driver source 
and this caught my eye:
http://lxr.linux.no/#linux+v3.3/drivers/media/video/uvc/uvc_v4l2.c#L671

678: int pin = 0;
...
689: } else if (pin < selector->bNrInPins) {
...
690: pin = selector->baSourceID[index];

pin is always 0 in the comparison, was this intended?
(wasn't the line 690 supposed to be before the comparison?
or the index to be compared  to bNrInPins?)

Please excuse me wasting your tine if it is a total nonsense. 
Sincerely 

Jozef Vesely
vesely@....sk

PS: I am looking for a reason why MJPEG stopped working
on my cameras (long time ago), any hints?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/