linux-kernel - Re: [PATCH] checkpatch: Check for quoted strings broken across lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1332331883.29403.31.camel@joe2Laptop>
Date:	Wed, 21 Mar 2012 05:11:23 -0700
From:	Joe Perches <joe@...ches.com>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	Andy Whitcroft <apw@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Check for quoted strings broken across lines

On Tue, 2012-03-20 at 23:05 -0700, Josh Triplett wrote:
> On Tue, Mar 20, 2012 at 09:35:58PM -0700, Joe Perches wrote:
> > One improvement might be to check for a line continuation \
> > on $prevline and still produce a warning in that case.
> 
> I'd suggest doing that one as a separate check, "unnecessary line
> continuation", which should flag any use of a line continuation other
> than with a preprocessor directive.  I don't think combining that with
> the wrapped-string check makes sense.

What I suggested is for a case in a #define:

#define subsystem_printk(subsystem, level, format, ...)			\
	netdev_printk(level, (subsystem)->dev, "Some partial format "	\
		      "continued on another line" format,		\
		      ##__VA_ARGS__)

where it's necessary to use line continuations but rewrapping like:

#define subsystem_printk(subsystem, level, format, ...)			\
	netdev_printk(level, (subsystem)->dev, 				\
		      "A coalesced format on a single line" format,	\
 		      ##__VA_ARGS__)

might improve it.

Anyway:

Acked-by: Joe Perches <joe@...ches.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/