[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1332304558.29403.17.camel@joe2Laptop>
Date: Tue, 20 Mar 2012 21:35:58 -0700
From: Joe Perches <joe@...ches.com>
To: Josh Triplett <josh@...htriplett.org>
Cc: Andy Whitcroft <apw@...onical.com>,
Andrew Morton <akpm@...ux-foundation.org>,
"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Check for quoted strings broken across lines
On Tue, 2012-03-20 at 21:28 -0700, Josh Triplett wrote:
> On Tue, Mar 20, 2012 at 06:24:16PM -0700, Joe Perches wrote:
> > I don't recall seeing your patch before, but I submitted
> > a similar one that I believe Andrew has in his tree.
> You reviewed my patch at the time and provided feedback, and I'd
> produced a revised version based on that feedback.
duh.
I heard short term memory fades as you get age,
but I might not remember that in awhile.
> The heuristics in the patch I submitted almost completely eliminate
> false positives, which makes my patch suitable for use without --strict.
Yup, this patch is better than the one I submitted.
One improvement might be to check for a line continuation \
on $prevline and still produce a warning in that case.
cheers, Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists