lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1332512896.23924.66.camel@gandalf.stny.rr.com>
Date:	Fri, 23 Mar 2012 10:28:16 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ajeet Yadav <ajeet.yadav.77@...il.com>
Cc:	John Stultz <john.stultz@...aro.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: Not able to use HIGH_RES_TIMERS on ARM

On Fri, 2012-03-23 at 14:40 +0530, Ajeet Yadav wrote:

> linux-3.0.20/kernel/trace/Kconfig
> linux-3.0.20-dirty/kernel/trace/Kconfig
> --- linux-3.0.20/kernel/trace/Kconfig   2012-02-06 23:01:45.000000000 +0530
> +++ linux-3.0.20-dirty/kernel/trace/Kconfig     2012-03-19
> 18:21:41.000000000 +0530
> @@ -173,7 +173,6 @@ config IRQSOFF_TRACER
>        bool "Interrupts-off Latency Tracer"
>        default n
>        depends on TRACE_IRQFLAGS_SUPPORT
> -       depends on !ARCH_USES_GETTIMEOFFSET
>        select TRACE_IRQFLAGS
>        select GENERIC_TRACER
>        select TRACER_MAX_TRACE
> @@ -195,7 +194,6 @@ config IRQSOFF_TRACER
>  config PREEMPT_TRACER
>        bool "Preemption-off Latency Tracer"
>        default n
> -       depends on !ARCH_USES_GETTIMEOFFSET
>        depends on PREEMPT
>        select GENERIC_TRACER
>        select TRACER_MAX_TRACE

A little history here.

When I converted the irqsoff/preemptoff latency tracers from the
original -rt patch (written by Ingo), these options originally had
"depends on GENERIC_TIME". I just checked, and this goes at least back
to 2.6.22.1-rt9 (long before ftrace).

When I ported these to ftrace, I kept the dependencies. They probably
are not needed and are only there for historical reasons.

If this patch works fine for you, and that you are my only test case for
this patch. I'd just say:

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ