lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Mar 2012 17:28:55 +0200 From: Alex Gershgorin <alexg@...rolight.com> To: Mark Brown <broonie@...nsource.wolfsonmicro.com> CC: "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "fabio.estevam@...escale.com" <fabio.estevam@...escale.com> Subject: RE: [PATCH v1] regulator: i.MX35-PDK Add regulator support Hi Mark, Thanks for you quick responds and comments. On Mon, Mar 26, 2012 at 04:36:33PM +0200, Alex Gershgorin wrote: > +static struct regulator_init_data sw1_init = { > + .constraints = { > + .name = "SW1", > + .min_uV = 600000, > + .max_uV = 1375000, > + .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE, > + .valid_modes_mask = 0, > + .always_on = 1, > + .boot_on = 1, > + } > +}; > >These constraints don't make sense, you've got a voltage range and the > >ability to change voltages but no consumers so nothing that could ever > >change the voltage... Yes, you are right I will add consumers. > +static struct regulator_init_data vpll_init = { > + .constraints = { > + .name = "VPLL", > + .min_uV = 1050000, > + .max_uV = 1800000, > + .valid_ops_mask = REGULATOR_CHANGE_VOLTAGE, > + .boot_on = 1, > + } > +}; > >...and in many cases the supply names don't look like things I'd expect > >to be varying too much at runtime. It looks like you just typed the > >maximum datasheet ranges in, not things that make sense for the board. It's not quite true, I was based on the Freescale BSP and I assume, that this is checked. I also tested it on v3.3 Regards, Alex Gershgorin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists