linux-kernel - Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to do_sparc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFPAmTSyYJkATAD32WqHZY_PdWGjitEq4vgqCZeqjo+V24dh3Q@mail.gmail.com>
Date:	Mon, 26 Mar 2012 12:20:17 -0400
From:	Kautuk Consul <consul.kautuk@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	davem@...emloft.net, Paul Gortmaker <paul.gortmaker@...driver.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to do_sparc_fault

> David meant that the indentation should be aligned
> immediately after the open parenthesis:
>
> +       unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> +                             (write ? FAULT_FLAG_WRITE : 0));
>
> though perhaps this is clearer as:
>
>        unsigned int flags = FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE;
>
>        if (write)
>                flags |= FAULT_FLAG_WRITE;
>
> or even separate sets.
>
>        if (write)
>                flags = foo;
>        else
>                flags = bar;

This is how it is in the patch file(immediately after the paramthesis).
I have now attached both sparc patches to this email.

you must be having the same problem in viewing the patch file
as me due to the email client itself inserting invalid spaces here and there.

by the way, what tab-spaces are you using when you open it in vim ?

View attachment "0019-sparc-mm-fault_32.c-Port-OOM-changes-to-do_page_faul.patch" of type "text/x-patch" (2869 bytes)

View attachment "0020-sparc-mm-fault_64.c-Port-OOM-changes-to-do_page_faul.patch" of type "text/x-patch" (2856 bytes)