linux-kernel - Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to do_sparc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120326163644.GA23176@merkur.ravnborg.org>
Date:	Mon, 26 Mar 2012 18:36:44 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Kautuk Consul <consul.kautuk@...il.com>
Cc:	davem@...emloft.net, Paul Gortmaker <paul.gortmaker@...driver.com>,
	Ingo Molnar <mingo@...e.hu>, Joe Perches <joe@...ches.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to
	do_sparc_fault

On Mon, Mar 26, 2012 at 11:32:26AM -0400, Kautuk Consul wrote:
> Commit d065bd810b6deb67d4897a14bfe21f8eb526ba99
> (mm: retry page fault when blocking on disk transfer) and
> commit 37b23e0525d393d48a7d59f870b3bc061a30ccdb
> (x86,mm: make pagefault killable)
> 
> The above commits introduced changes into the x86 pagefault handler
> for making the page fault handler retryable as well as killable.
> 
> These changes reduce the mmap_sem hold time, which is crucial
> during OOM killer invocation.
> 
> Port these changes to 32-bit sparc.
> 
> Signed-off-by: Kautuk Consul <consul.kautuk@...il.com>
> ---
>  arch/sparc/mm/fault_32.c |   37 ++++++++++++++++++++++++++++++-------
>  1 files changed, 30 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/sparc/mm/fault_32.c b/arch/sparc/mm/fault_32.c
> index 8023fd7..6da1818 100644
> --- a/arch/sparc/mm/fault_32.c
> +++ b/arch/sparc/mm/fault_32.c
> @@ -226,6 +226,8 @@ asmlinkage void do_sparc_fault(struct pt_regs *regs, int text_fault, int write,
>  	unsigned long g2;
>  	int from_user = !(regs->psr & PSR_PS);
>  	int fault, code;
> +	unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> +						  (write ? FAULT_FLAG_WRITE : 0));
Hi Kautuk.

The indention still look like shit.
It looks like this (tabs converted to spaces):
        unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
                                          (write ? FAULT_FLAG_WRITE : 0));


	Sam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/