linux-kernel - Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to do_sparc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFPAmTTAf660w7Xcidzi5KHrJoDSEiWJdOMhyUesGxih8bs1wA@mail.gmail.com>
Date:	Mon, 26 Mar 2012 12:55:56 -0400
From:	Kautuk Consul <consul.kautuk@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	davem@...emloft.net, Paul Gortmaker <paul.gortmaker@...driver.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to do_sparc_fault

>>
>> you must be having the same problem in viewing the patch file
>> as me due to the email client itself inserting invalid spaces here and there.
>
> Nope.  That's not it.
>
>> by the way, what tab-spaces are you using when you open it in vim ?
>
> I use vim as an editor as infrequently as possible.
>
> Your original patch used 6 tabs and 2 spaces.
> Tab size in kernel style is always 8.
>
> Again, make sure your tab indentation is set to 8.
>

I see what you are saying.
One question: Is it possible to include this kinda checking
(multiline statements with paranthesis checking assuming tab
indentation 8) in the
checkpatch.pl script ?
It would be easier to not make such mistakes in future with that kind of tool.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/