linux-kernel - RE: [PATCH v3] regulator: Add TPS65090 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D958900912E20642BCBC71664EFECE3E6DD312816F@BGMAIL02.nvidia.com>
Date:	Mon, 26 Mar 2012 09:23:06 +0530
From:	Venu Byravarasu <vbyravarasu@...dia.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"lrg@...com" <lrg@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] regulator: Add TPS65090 regulator driver

> >
> > TPS65090 PMIC from TI consists of 3 step down converters,
> > 2 always on LDOs and 7 current limited load switches. The
> > output voltages are ON/OFF controllable and are meant to
> > supply power to the components on target board.
> 
> Applied, but...
> 
> > +	rdev = regulator_register(&ri->desc, &pdev->dev,
> > +				&tps_pdata->regulator, ri, NULL);
> > +	if (IS_ERR_OR_NULL(rdev)) {
> 
> ...please submit an incremental patch changing this to plain IS_ERR(),
> regulator_register() only returns error pointers.  Note that no other
> regulator drivers do this check.
Thanks Mark, for applying this patch.
As Axel already provided a patch to fix this, Acked on his patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/