linux-kernel - Re: [PATCH v3] regulator: Add TPS65090 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120322160256.GK3091@opensource.wolfsonmicro.com>
Date:	Thu, 22 Mar 2012 16:02:56 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
Cc:	lrg@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] regulator: Add TPS65090 regulator driver

On Thu, Mar 22, 2012 at 06:34:09PM +0530, Venu Byravarasu wrote:
> Add TPS65090 regulator driver
> 
> TPS65090 PMIC from TI consists of 3 step down converters,
> 2 always on LDOs and 7 current limited load switches. The
> output voltages are ON/OFF controllable and are meant to
> supply power to the components on target board.

Applied, but...

> +	rdev = regulator_register(&ri->desc, &pdev->dev,
> +				&tps_pdata->regulator, ri, NULL);
> +	if (IS_ERR_OR_NULL(rdev)) {

...please submit an incremental patch changing this to plain IS_ERR(),
regulator_register() only returns error pointers.  Note that no other
regulator drivers do this check.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)