linux-kernel - Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to do_sparc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120326.160923.1071907261787727015.davem@davemloft.net>
Date:	Mon, 26 Mar 2012 16:09:23 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	consul.kautuk@...il.com
Cc:	paul.gortmaker@...driver.com, mingo@...e.hu, joe@...ches.com,
	a.p.zijlstra@...llo.nl, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/20 v3] sparc/mm/fault_32.c: Port OOM changes to
 do_sparc_fault

From: Kautuk Consul <consul.kautuk@...il.com>
Date: Mon, 26 Mar 2012 11:32:26 -0400

> +	unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> +						  (write ? FAULT_FLAG_WRITE : 0));

Indentation is still wrong.  The "(write ..." on the second line must
line up with the column of the first "F" in "(FAULT_FLAG..." on the
first line.

+			perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
+						  1, regs, address);

+			perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN,
+						  1, regs, address);

These are still wrong too, for the same reason.

You didn't fix anything.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/