linux-kernel - Re: [PATCH 20/20 v3] sparc/mm/fault_64.c: Port OOM changes to do_sparc64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120326.161105.1592652605352070253.davem@davemloft.net>
Date:	Mon, 26 Mar 2012 16:11:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	consul.kautuk@...il.com
Cc:	paul.gortmaker@...driver.com, mingo@...e.hu, joe@...ches.com,
	a.p.zijlstra@...llo.nl, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 20/20 v3] sparc/mm/fault_64.c: Port OOM changes to
 do_sparc64_fault

From: Kautuk Consul <consul.kautuk@...il.com>
Date: Mon, 26 Mar 2012 11:33:17 -0400

> +	fault = handle_mm_fault(mm, vma, address,
> +							flags | ((fault_code & FAULT_CODE_WRITE) ?
> +									 FAULT_FLAG_WRITE : 0);

This is so shockingly gross I'm at a loss for words.  Why are you
tabbing this crap all the way into outer-space?

Make the "flags | ..." line up with the first column after the
openning parenthesis of "handle_mm_fault(".

> +			perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
> +						  1, regs, address);

Same problem.

> +			perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN,
> +						  1, regs, address);

Same problem.

You're making the coding style worse each iteration, not better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/