linux-kernel - Re: [PATCH v4] x86, olpc: add debugfs interface for EC commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 18:13:25 -0400
From:	Paul Fox <pgf@...top.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Daniel Drake <dsd@...top.org>, mingo@...hat.com,
	tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org, dilinger@...ued.net
Subject: Re: [PATCH v4] x86, olpc: add debugfs interface for EC commands

andrew wrote:
 > On Mon, 26 Mar 2012 19:07:07 +0100 (BST)
 > Daniel Drake <dsd@...top.org> wrote:
 > 
 > > Add a debugfs interface for sending commands to the OLPC Embedded
 > > Controller (EC) and reading the responses.  The EC provides functionality
 > > for machine identification, battery and AC control, wakeup control, etc.
 > > 
 > > Having a debugfs interface available is useful for EC development and
 > > debugging.
 > > 
 > > Based on code by Paul Fox.
 > > 
 > > Signed-off-by: Daniel Drake <dsd@...top.org>
 > > Originally-from: Paul Fox <pgf@...top.org>
 > > Cc: Ingo Molnar <mingo@...e.hu>
 > > Cc: Thomas Gleixner <tglx@...utronix.de>
 > > Cc: "H. Peter Anvin" <hpa@...or.com>
 > > Cc: Andres Salomon <dilinger@...ued.net>
 > > 
 > > ...
 > >
 > > v4: really fix sign-off tags
 > 
 > s/fix/break/?  "Originally-from" is not a recognised tag.  If this code
 > is based upon an earlier version from Paul then Signed-off-by: is
 > correct.
 > 
 > What's going on here?  What are you trying to communicate?


i think the way daniel had it before was likely correct.

i wrote the original code, but it looked pretty different back then. 
daniel has brought it to its current state.  i _then_ added my
Signed-off-by.

so the code is both "Based on code by Paul Fox", and my Signed-off-by
should come after daniel's (assuming chronological order).

paul
=---------------------
 paul fox, pgf@...top.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/