lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Mar 2012 18:28:43 -0700 From: Joe Perches <joe@...ches.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Dave Jones <davej@...hat.com>, Dave Chinner <david@...morbit.com>, viro@...iv.linux.org.uk, Linux Kernel <linux-kernel@...r.kernel.org>, David Rientjes <rientjes@...gle.com> Subject: Re: suppress page allocation failure warnings from sys_listxattr On Wed, 2012-03-28 at 18:10 -0700, Andrew Morton wrote: > On Wed, 28 Mar 2012 20:54:42 -0400 Dave Jones <davej@...hat.com> wrote: > > > Yup. How does the below look? > > Don't see anything immediately wrong with it. > > Any thoughts on what to do about the similar problem in setxattr ? (memdup_user) [] > diff -puN fs/xattr.c~fs-xattrc-setxattr-improve-handling-of-allocation-failures fs/xattr.c [] > @@ -334,13 +335,25 @@ setxattr(struct dentry *d, const char __ [] > + kvalue = kmalloc(size, GFP_KERNEL | __GFP_NOWARN); > + if (!kvalue) { > + vvalue = vmalloc(size); [] > + if (vvalue) > + vfree(vvalue); > + else > + kfree(kvalue); > return error; These patterns are pretty common, maybe create a standard helper? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists